[system-health] Led color shall be controlled by configuration when system is booting #154
+25
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Oct 24, 2022
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jan 9, 2023
7a7d847 Jing Zhang Fri Nov 4 17:12:51 2022 -0700 [active-active] Incrementing BOOST_ASIO_STRAND_IMPLEMENTATIONS (#154) sign-off: Jing Zhang [email protected]
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jan 28, 2023
ac24ad1 Liu Shilong Wed Nov 30 18:04:15 2022 +0800 Use github code scanning instead of LGTM (#157) 1c755c4 Jing Zhang Fri Nov 4 17:12:51 2022 -0700 [active-active] Incrementing BOOST_ASIO_STRAND_IMPLEMENTATIONS (#154) sign-off: Jing Zhang [email protected]
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Sep 25, 2024
…utomatically (sonic-net#20067) #### Why I did it src/sonic-host-services ``` * 052a797 - (HEAD -> 202311, origin/202311) Change dependency option to fix buildimage issue. (#110) (10 hours ago) [Feng-msft] * 6ab6243 - Fix UT test data due to timestamp break. (#117) (10 hours ago) [Feng-msft] * 7a68e40 - Update ProcessStats query by using API instead of parsing ps command. (#103) (#154) (11 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently, system status LED is always red during booting stage. User cannot tell if it is a real issue or system is under initialization. This HLD change introduces a booting stage for the system health daemon and allow user to configure the system status led color for booting state.
How I did it
Led color is determined by system status and uptime.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)