Amelia tomas/event schema #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkim10
reviewed
Oct 25, 2024
scripts/eventTest.ts
Outdated
| @@ -0,0 +1,39 @@ | |||
| // TO RUN: npx ts-node scripts/eventTest.ts | |||
There was a problem hiding this comment.
Can you guys delete this file from the PR? I think ideally we wanna only keep files that the webapp will need (so omit testing files)
wkim10
reviewed
Oct 25, 2024
src/components/ExampleButton.tsx
Outdated
| }, | ||
| }, | ||
| }); | ||
| // const response2 = await deleteEvent({ |
There was a problem hiding this comment.
nit: remove the commented-out testing
wkim10
reviewed
Oct 25, 2024
src/app/api/event/route.client.ts
Outdated
| // DateTime: Date; | ||
| // }; | ||
| export const addEvent = async (request: { | ||
| body: { event: Partial<Event> }; |
There was a problem hiding this comment.
Instead of Partial I think we should use the Pick keyword in TypeScript so we can make things more specific like this:
type CreateEventInput = Pick<Event, "EventName" | "Description" | "MaxPeople" | "DateTime">
wkim10
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created Event Schema, made the POST, PUT, and DELETE.
Issues
No issues!
Screenshots
Backend - no screenshots.
Test
Use the button.tsx to test our methods.
Possible Downsides
We weren't sure about the Partial Event on the client side.
Additional Documentations