deleted seniors, request, and chapter #173
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Your changes are functionally correct! Echoing @sburchfield33 feedback, I think we can condensed the code a bit further. As mentioned, we want to reduce the number of API calls. This is important for a couple of reasons:
- Less network traffic is usually better
- Prisma handles transaction for us within 1 API call
In summary,
- We can use
onDelete: CascadeforUserRequest - Unset relationship on user side when a chapter is deleted. You may find this doc helpful.
nickbar01234
force-pushed
the
nathan/tyler/delete-chapter
branch
from
013a0d6 to
afebb72
Compare
| @@ -131,6 +131,8 @@ model ChapterRequest { | |||
| motivation String | |||
| availabilities String | |||
| questions String | |||
|
|
|||
There was a problem hiding this comment.
Is a chapterid field not necessary here?
| @@ -144,6 +146,11 @@ model Chapter { | |||
| // Google Drive API related fields | |||
| chapterFolder String @default("") | |||
| permissions String[] | |||
|
|
|||
| chapterRequestId String @db.ObjectId @unique | |||
| chapterRequest ChapterRequest @relation(fields: [chapterRequestId], references: [id], onDelete: Cascade) | |||
There was a problem hiding this comment.
Shouldn't the onDelete cascade be on the ChapterRequest field here? Wouldn't the onDelete here just delete the chapter if the chapterrequest is deleted?
I assume what you are trying to do here is delete the ChapterRequest if the chapter is deleted so I believe the onDelete should be on the chapterrequest side.
Description
Issues
#155
Screenshots
No user interface changes
Test
Submit new chapter request and accept. Add members, seniors, and files. Delete chapter and check database.