Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse row #165

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Collapse row #165

merged 3 commits into from
Apr 16, 2024

Conversation

nickbar01234
Copy link
Collaborator

Description

  • Collapse input on smaller size screen
  • Add max length to input to prevent malicious users from abusing the database

johnny-t06
johnny-t06 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@johnny-t06 johnny-t06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I corrected some of the name fields of ErrorMessage. Tested responsiveness and validation of the form. Nice work!

@nickbar01234 nickbar01234 merged commit 476a3bf into main Apr 16, 2024
4 checks passed
@nickbar01234 nickbar01234 deleted the nickbar01234/start-chapter-responsive branch April 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny-t06 johnny-t06 johnny-t06 approved these changes

@wkim10 wkim10 Awaiting requested review from wkim10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickbar01234 @johnny-t06