Deprecate pages #154
Merged
Deprecate pages #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickbar01234
commented
Apr 12, 2024
| @@ -1,6 +1,5 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
This changes is generated on npm run build, because useRouter does not have to support both pages/ and app/
Co-authored-by: wkim10 <[email protected]> Co-authored-by: johnny-t06 <[email protected]>
nickbar01234
force-pushed
the
nickbar01234/deprecate-pages
branch
from
bd38599 to
2d555bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate
pages/directory as we have a workingapp/directory implementation.Methodology
npm run buildshould return with non-zero status.Possible Downsides
There will be a big diff when merged.
Additional Documentation
We will be deprecating
components/next.