Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed nits and styling bugs #148

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

nathan-j-edwards
Copy link
Collaborator

Description

  • Combined portions of code to make it look cleaner
  • Set default date to current date and added error message if file for current date already exists
  • Made pop up scrollable
  • Sorted files by date
  • Fixed minor styling bugs
  • Added loading message after file submitted
  • Made page reload automatically after file creation

Issues

Fixed issues from pull request #128

Screenshots

Screenshot (35)

Screenshot (36)

Screenshot (37)

Test

You should be able to create files for your assigned senior from a user account. Files will populate after creation.

Possible Downsides

There may be a minor bug that requires you to click the create button multiple times before the request goes through. We were unable to tell for sure given the amount of time it takes for the file to create.

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
the-legacy-project2 ✅ Ready (Inspect) Visit Preview Apr 9, 2024 7:20pm

@nickbar01234 nickbar01234 force-pushed the Tia-Chen-nathan-j-edwards-add-new-file-popup-2 branch from 3e89c48 to 3611e61 Compare April 9, 2024 21:09
@nickbar01234 nickbar01234 force-pushed the Tia-Chen-nathan-j-edwards-add-new-file-popup-2 branch from e6fc2fe to 2ad6bfb Compare April 9, 2024 21:24
Copy link
Collaborator

@nickbar01234 nickbar01234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys! I pushed some styling changes to update the error popup and adjusted the position for the file popup. I will go ahead and merge the changes for our sponsor meeting.

@nickbar01234 nickbar01234 merged commit 820221b into main Apr 9, 2024
3 of 4 checks passed
@nickbar01234 nickbar01234 deleted the Tia-Chen-nathan-j-edwards-add-new-file-popup-2 branch April 9, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants