collapsible items in univ home page and chapter requests #145
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| tiles={userRequests.map((user, index) => { | ||
| return ( | ||
| <PendingCard | ||
| key={index} |
There was a problem hiding this comment.
@nickbar01234 is it more safe to use user.uid as the key? I've had some problems when using the index for the key.
There was a problem hiding this comment.
Yep, I agree. In general, it's safer to not use index, as items in a list can be shifted / re-ordered. I think in this case, it's fine, because userRequests are passed from the server, and we refresh the page every time. You can find more details here
| tiles={userRequests.map((user, index) => { | ||
| return ( | ||
| <PendingCard | ||
| key={index} |
There was a problem hiding this comment.
Yep, I agree. In general, it's safer to not use index, as items in a list can be shifted / re-ordered. I think in this case, it's fine, because userRequests are passed from the server, and we refresh the page every time. You can find more details here
nickbar01234
force-pushed
the
tyler/julia/collapse
branch
from
6ae1bd5 to
baa2c1b
Compare
|
Merging ahead for our sponsor meeting! |
No description provided.