Cledi selena edit senior #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickbar01234
reviewed
Mar 5, 2024
nickbar01234
reviewed
Mar 5, 2024
nickbar01234
reviewed
Mar 5, 2024
nickbar01234
reviewed
Mar 5, 2024
nickbar01234
reviewed
Mar 5, 2024
nickbar01234
reviewed
Mar 5, 2024
| @@ -3,7 +3,8 @@ import { z } from "zod"; | |||
|
|
|||
| export const seniorSchema = z.object({ | |||
There was a problem hiding this comment.
Can we potentially use this instead of redefining postSeniorSchema and patchSeniorSchema?
nickbar01234
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Great job guys :) I only have a couple of small feedbacks.
- I noticed that you had to change quite a few places with the new schema changes. I think we can utilize the senior schema defined in
models/to reduce work in the future. - Double check the routing in top-level
layout.tsxfor chapter leaders. - When you render items for
CardGrid, don't forget to include a key.
nickbar01234
force-pushed
the
cledi-selena-edit-senior
branch
from
cf9a050 to
6c94553
Compare
nickbar01234
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change senior field to have firstname and lastname in the database, instead of just one
namefield. Also created a page for chapter leader to view seniors, as well as add new ones @/private/[uid]/chapter-leader/seniors.Linked front-end senior add pop-up component to the senior API in the new backend route.
Issues
No issue was made for this.
Test
Run npx prisma generate to update the PrismaClient. Then, add a new senior in the /private/[uid]/chapter-leader/seniors page.
Possible Downsides
Lacks logic to validate whether the user is a chapter leader. Double check if the logic to fetch the user, fetch the chapter, fetch the corresponding seniors in that chapter, is in line with intended business logic.