Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belgian layout #780

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Belgian layout #780

wants to merge 3 commits into from

Conversation

ptitgnu
Copy link

@ptitgnu ptitgnu commented Oct 4, 2024

Adds Belgian AZERTY layout used in Belgium for Dutch, French and German languages.

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) I've left some comments.

<key key0="j" key1="è" key2="accent_trema" key3="accent_circonflexe"/>
<key key0="k" key1="€" key2="*" key3="$"/>
<key key0="l" key1="loc accent_caron" key2="%" key3="ù" key4="accent_aigu"/>
<key key0="m" key1="loc accent_breve" key2="£" key3="µ" key4="accent_grave"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard contains àèù, is accent_grave useful ? For occasionally writing other accented letters, isn't the compose key enough ?
It's also possible to make this key appear only if the user has a language that needs it installed on their device.

Same for accent_aigu and accent_cedille, éç are already on the keyboard.

<key key0="o" key1="loc accent_ogonek" key2="9" key3="à" key4="loc accent_cedille"/>
<key key0="p" key2="0" key3="-" key1="_"/>
</row>
<row>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ is missing on the keyboard. It's useful to type with the compose key and might be used in passwords.
accent_tilde is not a substitute because it doesn't work with the compose key.

<key key0="j" key1="è" key2="accent_trema" key3="accent_circonflexe"/>
<key key0="k" key1="€" key2="*" key3="$"/>
<key key0="l" key1="loc accent_caron" key2="%" key3="ù" key4="accent_aigu"/>
<key key0="m" key1="loc accent_breve" key2="£" key3="µ" key4="accent_grave"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

£ and accent_grave are very close to the edge of the screen and might be hard to type. What do you think of moving more of the side characters to the right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants