Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somfy dexxo smart io garage door support #59

Merged
merged 2 commits into from
Dec 30, 2020
Merged

somfy dexxo smart io garage door support #59

merged 2 commits into from
Dec 30, 2020

Conversation

otokarl
Copy link

@otokarl otokarl commented Dec 30, 2020

This PR is to add support of dexxo smart io.
Tested on my garage door installation.

@coveralls
Copy link

coveralls commented Dec 30, 2020

Coverage Status

Coverage remained the same at 81.631% when pulling 3aceed6 on otokarl:otokarl_dexxo into a1c4419 on Julius2342:master.

@Julius2342
Copy link
Owner

some linting errors:

see: https://travis-ci.org/github/Julius2342/pyvlx/jobs/752130284

pyvlx/node_helper.py:94:6: C0303: Trailing whitespace (trailing-whitespace)

pyvlx/node_helper.py:95:0: W0311: Bad indentation. Found 5 spaces, expected 8 (bad-indentation)

pyvlx/node_helper.py:133:6: C0303: Trailing whitespace (trailing-whitespace)

and

./pyvlx/node_helper.py:94:7: W291 trailing whitespace

./pyvlx/node_helper.py:95:6: E111 indentation is not a multiple of four

./pyvlx/node_helper.py:96:13: E126 continuation line over-indented for hanging indent

./pyvlx/node_helper.py:101:9: E121 continuation line under-indented for hanging indent

./pyvlx/node_helper.py:133:7: W291 trailing whitespace

./test/node_helper_test.py:234:10: W292 no newline at end of file


@otokarl
Copy link
Author

otokarl commented Dec 30, 2020

some linting errors:

see: https://travis-ci.org/github/Julius2342/pyvlx/jobs/752130284

pyvlx/node_helper.py:94:6: C0303: Trailing whitespace (trailing-whitespace)

pyvlx/node_helper.py:95:0: W0311: Bad indentation. Found 5 spaces, expected 8 (bad-indentation)

pyvlx/node_helper.py:133:6: C0303: Trailing whitespace (trailing-whitespace)

and

./pyvlx/node_helper.py:94:7: W291 trailing whitespace

./pyvlx/node_helper.py:95:6: E111 indentation is not a multiple of four

./pyvlx/node_helper.py:96:13: E126 continuation line over-indented for hanging indent

./pyvlx/node_helper.py:101:9: E121 continuation line under-indented for hanging indent

./pyvlx/node_helper.py:133:7: W291 trailing whitespace

./test/node_helper_test.py:234:10: W292 no newline at end of file

Ok, fixed now.
What is the next step?

@Julius2342 Julius2342 merged commit 2c19f35 into Julius2342:master Dec 30, 2020
@otokarl otokarl deleted the otokarl_dexxo branch December 30, 2020 19:58
@jirkapas
Copy link

Hi,
I don't want to be super annoying, but I would like to connect my Dexxo IO motor to Home Assistant. But the version of pyvlx that contains this update is not currently used by the Velux integration in Home Assistant.
Can someone that knows what's they are doing create a Home Assistant pull request that would update pyvlx to version 0.2.19? Because I don't know what I'm doing when in comes to creating a proper pull request.

Thanks a lot to anyone who would consider creating this pull request for me.

@Julius2342
Copy link
Owner

Thank you @tikismoke !

@jirkapas
Copy link

@tikismoke I also thank you. 😀

@tikismoke
Copy link

home-assistant/core#49533 (comment)
@jirkapas could you have a look?

@jirkapas
Copy link

home-assistant/core#49533 (comment)
@jirkapas could you have a look?

@tikismoke I'm not really a developer. But I checked some of the previous pyvlx dependency bump PR's and they all also changed the pyvlx version in requirements_all.txt. See: home-assistant/core@afb6788

MartinHjelmare pushed a commit to home-assistant/core that referenced this pull request Apr 22, 2021
* Update manifest.json

Julius2342/pyvlx#59 (comment)

* Update requirements_all.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants