Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot KLF200 on disconnect #366

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Reboot KLF200 on disconnect #366

merged 3 commits into from
Feb 19, 2024

Conversation

pawlizio
Copy link
Collaborator

@pawlizio pawlizio commented Dec 30, 2023

I think we should include the reboot function directly into KLF200 disconnect command. I know the KLF200 open it's WIFI Access Point on restart, however you need to have the creditentials to connect to this AP, so I think this solution can be justified as workaround.

This PR is a workaround to avoid #53, #68 and #30

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e545e4c) 80.00% compared to head (8f85d94) 79.97%.
Report is 1 commits behind head on master.

Files Patch % Lines
pyvlx/pyvlx.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   80.00%   79.97%   -0.03%     
==========================================
  Files          77       77              
  Lines        3560     3561       +1     
==========================================
  Hits         2848     2848              
- Misses        712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawlizio
Copy link
Collaborator Author

@Julius2342 : What do think? Moreover, can you create a new release? Finally I could do that on my own, as you gave me the rights. However currently the upload to pypi is not automated and there I don't have the permissions. For this you could add an action to automatically upload to to pypi as described here: https://github.com/marketplace/actions/pypi-publish

@Julius2342 Julius2342 merged commit a6d391b into Julius2342:master Feb 19, 2024
4 checks passed
@Julius2342
Copy link
Owner

If you tell me your pypi account id, i think i can add you ...

@pawlizio
Copy link
Collaborator Author

It's the same as here in github, pawlizio

@Julius2342
Copy link
Owner

Added you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants