Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which Python versions are supported? #337

Closed
palfrey opened this issue Sep 23, 2023 · 4 comments
Closed

Which Python versions are supported? #337

palfrey opened this issue Sep 23, 2023 · 4 comments

Comments

@palfrey
Copy link
Collaborator

palfrey commented Sep 23, 2023

The setup.py lists 3.5 and 3.6, but the CI tests 3.8-3.11. Which are the officially supported versions?
@palfrey
Copy link
Collaborator Author

palfrey commented Nov 23, 2023

@Julius2342 Any thoughts on this one?

@Julius2342
Copy link
Owner

This is probably just bc nobody updated it for a long time :)

As the most common usecase is home-assistant, and there the minumum version is 3.10 I would say we change the supported versions to 3.10, 3.11 (and probably 3.9 if that does not ship with too much costs).

What do you think?

@palfrey
Copy link
Collaborator Author

palfrey commented Nov 24, 2023

3.9-3.11 sounds good to me. There's some gains from not working with 3.9, but not a lot IIRC.

Julius2342 added a commit that referenced this issue Nov 24, 2023
@Julius2342
Issue #337: Set minimum required python version to 3.9
f389bb6
Julius2342 added a commit that referenced this issue Nov 25, 2023
@Julius2342
Set Minimum python version to 3.9 (#352)
936e23b 
* Issue #337: Set minimum required python version to 3.9

* Set python_requires in setup.py

* add support for 3.12
@Julius2342
Copy link
Owner

Short update here, decided to also ditch 3.9 and go for [3.10,3.11,3,12] bc of better typehint support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palfrey @Julius2342