Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement A065722 Paterson Primes #391

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

kshitij10496
Copy link
Contributor

@kshitij10496 kshitij10496 commented Nov 14, 2023

Hi 👋 !

Thanks a lot for this project.

While watching the Numberphile video on Paterson Primes, I stumbled on OEIS. I felt curious to implement a basic algorithm to generate the sequence A065722.

This change introduces an implementation based on SymPy library.
Please take a look and let me know if I'm on the correct track.
I would also appreciate if you can suggest any improvements.

oeis.py Outdated Show resolved Hide resolved
oeis.py Outdated Show resolved Hide resolved
@JulienPalard
Copy link
Owner

So I have another numberphile video to watch :D

Maybe it's their "fault" if I started this project in the first place ;)

@JulienPalard
Copy link
Owner

JulienPalard commented Nov 21, 2023

Damned, pylint does not get it:

oeis.py:763:13: E1133: Non-iterable value A000040 is used in an iterating context (not-an-iterable)

Let me check.

@JulienPalard
Copy link
Owner

Opened pylint-dev/pylint#9251 pylint side. In the meantime you can add a:

# pylint: disable=not-an-iterable

on line 763, or just add not-an-iterable to the pylint invocation in tox.ini, like this:

commands = pylint --disable import-outside-toplevel,invalid-name,not-an-iterable oeis.py

With maybe a link to the pylint issue near it so we don't loose the track of it.

@JulienPalard JulienPalard merged commit a9364c9 into JulienPalard:main Nov 22, 2023
3 checks passed
@JulienPalard
Copy link
Owner

It's merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants