Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report graph #41

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Report graph #41

wants to merge 9 commits into from

Conversation

raboof
Copy link
Collaborator

@raboof raboof commented May 31, 2024

a graph seems easier to read than a tree

https://arnout.engelen.eu/minimal.html

@raboof raboof marked this pull request as draft June 16, 2024 16:18
@raboof
Copy link
Collaborator Author

raboof commented Jun 16, 2024

moving this to draft because it makes it hard to search for derivations. not sure if this is the right direction.

@JulienMalka
Copy link
Owner

I like the design but I think we should have at least the tree view and as a nice to have the ability to switch between the views

@raboof
Copy link
Collaborator Author

raboof commented Jun 16, 2024

Possibly!

To give a bit of background: the reason I started going down this path is because I wanted to add 'filtering' to the report, so you could do things like "show me only the paths from the root to derivations that couldn't be reproduced". In the current tree representation, we remove common subtrees by replacing them with ... when the are encountered for the second time. That gets awkward when filtering.

Perhaps as a simpler intermediate state we should just have a 'flat' list of derivations that couldn't be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants