Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync option #1

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Sync option #1

wants to merge 33 commits into from

Conversation

JulienFuix
Copy link
Owner

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Julien Fuix and others added 30 commits February 6, 2024 16:01
adding new install
519a55f
adding new type and println
dc821d9
@anandf @blakepettersson @crenshaw-dev
docs(proposal): decoupling app sync from control plane user w/ impers…
5deff51 
…onation (argoproj#14255)

* Proposal for decoupling application sync from control plane user using impersonation

Signed-off-by: Anand Francis Joseph <[email protected]>

* Moved the proposal document to the right directory

Signed-off-by: Anand Francis Joseph <[email protected]>

* Update docs/decouple-application-sync-user-using-impersonation

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Update docs/decouple-application-sync-user-using-impersonation

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Update docs/decouple-application-sync-user-using-impersonation

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Modified the proposal to have control in AppProjects alone instead of Application and AppProject

Signed-off-by: Anand Francis Joseph <[email protected]>

* Removed proposal placed in wrong directory and corrected examples

Signed-off-by: Anand Francis Joseph <[email protected]>

* Update docs/proposals/decouple-application-sync-user-using-impersonation

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Update docs/proposals/decouple-application-sync-user-using-impersonation

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Addressed review comments

Signed-off-by: Anand Francis Joseph <[email protected]>

* Additional corrections

Signed-off-by: anandf <[email protected]>

* Fixed alternative proposals section to include only AppProject based approach

Signed-off-by: anandf <[email protected]>

* Added information on impersonation and added related links

Signed-off-by: anandf <[email protected]>

* Added examples for remote cluster destination with the required RBAC access

Signed-off-by: anandf <[email protected]>

* Fixed clusterrole and clusterrolebinding creation commands

Signed-off-by: anandf <[email protected]>

* Addressed review comments from Akram

Signed-off-by: anandf <[email protected]>

* Corrected RBAC to include serviceaccounts that can be impersonated as swell

Signed-off-by: anandf <[email protected]>

* Address few more review comments from Ishita, Akram

Signed-off-by: anandf <[email protected]>

* Fixed a typo and updated the last updated date field

Signed-off-by: anandf <[email protected]>

* Added information of the sync hook behaviour and also corrected the namespace to match that of destination

Signed-off-by: Anand Francis Joseph <[email protected]>

* Changed proposal to meet the latest api design using destinationServiceAccounts

Signed-off-by: Anand Francis Joseph <[email protected]>

* Fixed proposal document to use destinationServiceAccounts struct

Signed-off-by: Anand Francis Joseph <[email protected]>

* Renamed proposal file to have .md extension

Signed-off-by: anandf <[email protected]>

* Using glob pattern instead of regex, and corrected the order of precedence when multiple matches are available

Signed-off-by: anandf <[email protected]>

---------

Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: anandf <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
@blakepettersson @rbreeze @ishitasequeira
chore(ci): run ci checks conditionally (argoproj#16982)
3dff962 
* chore(ci): run ci checks conditionally

This should prevent docs changes from having the need to run e2e tests
etc, and prevent backend changes from needing to run ui tests, and vice
versa.

This is similar to previous attempts (see argoproj#16706 and argoproj#13507), with the
difference here that we add the if checks on each _step_ rather than
each _job_ - the reason being that most of these jobs are required, and
if we skip whole jobs any PR which does this will be left hanging
indefinitely, so Github forces us to do this on a step level instead.

Signed-off-by: Blake Pettersson <[email protected]>

* chore(ci): run ci checks conditionally

Try conditional jobs, according to https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Signed-off-by: Blake Pettersson <[email protected]>

* chore(ci): add composite test-e2e action

This is a workaround for the e2e tests which do not run yet report `pending` when they are actually skipped.

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Remington Breeze <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
@eshwarhs
fix(ui): Change path to "root" when path is root directory (argoproj#…
bf73b95 
…14949)

* change path to display root

Signed-off-by: Eshwar Hebbur Shivakumar <[email protected]>

* Fix inequality typo

Signed-off-by: Eshwar Hebbur Shivakumar <[email protected]>

* Fix lint issues

Signed-off-by: Eshwar Hebbur Shivakumar <[email protected]>

---------

Signed-off-by: Eshwar Hebbur Shivakumar <[email protected]>
@adam-huganir
typo registires -> registries (argoproj#17099)
1b22439 
Signed-off-by: Adam Huganir <[email protected]>
@yitzhtal @yitzhaktal @blakepettersson
Updated otelgrpc to remediate CVE found by JFrog Xray (argoproj#17084)
7b6eabe 
Signed-off-by: Tal Yitzhak <[email protected]>
Co-authored-by: Tal Yitzhak <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
@dosmanak
docs(webhook): use real cm name instead of placeholder (argoproj#17002)
c35fc2c 
The document says I should registed configMap named argocd-notifications-cm but then uses placeholder in examples.

Signed-off-by: Petr Studeny <[email protected]>
@jcourteau @todaywasawesome
docs: Update Okta OIDC SSO docs (argoproj#13811)
949068d 
* Update the Okta SSO docs

* fill out the OIDC section with step-by-step instructions on using Okta
  with custom authorization servers
* adjust outdated docs about updating the docs

Signed-off-by: Jonas Courteau <[email protected]>

* Add the Okta version that these docs are written against

Signed-off-by: Jonas Courteau <[email protected]>

---------

Signed-off-by: Jonas Courteau <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
@borisssmidtCET @borissmidt @pasha-codefresh
Add a description for using contour httpproxy CRD (argoproj#14614)
ba1bfb8 
Which allows you to reuse the same hostname.

Co-authored-by: Boris Smidt <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
@gdsoumya
fix: ci failures (argoproj#17107)
3f1fbb9 
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
@dependabot
chore(deps): bump library/golang from 1.21.3 to 1.22.0 in /test/remote (
5ed8f4a 
argoproj#17111)

Bumps library/golang from 1.21.3 to 1.22.0.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @pasha-codefresh
chore(deps-dev): bump yarn from 1.22.10 to 1.22.13 in /ui-test (argop…
04b0373 
…roj#17092)

Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.13.
- [Release notes](https://github.com/yarnpkg/yarn/releases)
- [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md)
- [Commits](yarnpkg/yarn@1.22.10...v1.22.13)

---
updated-dependencies:
- dependency-name: yarn
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <[email protected]>
@dependabot @pasha-codefresh
chore(deps): bump library/redis from 7.0.11 to 7.2.4 in /test/contain…
dd915d7 
…er (argoproj#16806)

Bumps library/redis from 7.0.11 to 7.2.4.

---
updated-dependencies:
- dependency-name: library/redis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <[email protected]>
@dependabot @blakepettersson @pasha-codefresh
chore(deps-dev): bump yarn from 1.22.10 to 1.22.21 in /ui (argoproj#1…
55e85c8 
…7096)

Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.21.
- [Release notes](https://github.com/yarnpkg/yarn/releases)
- [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md)
- [Commits](yarnpkg/yarn@1.22.10...v1.22.21)

---
updated-dependencies:
- dependency-name: yarn
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Pettersson <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
@soravkumarsharma
fix the typo (argoproj#17116)
ca4590a
@dependabot @pasha-codefresh
chore(deps): bump library/node from 20.6.1 to 21.6.1 (argoproj#17053)
551481c 
Bumps library/node from 20.6.1 to 21.6.1.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <[email protected]>
@fengshunli @pasha-codefresh
chore(deps): bump library/node from 20.7.0 to 21.6.1 (argoproj#17065)
9b888cf 
Signed-off-by: fengshunli <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
@prune998
fix(kustomize): set build dir (argoproj#15057) argoproj#16229 argopro…
773a681 
…j#16652 (argoproj#16653)

* use repo root, not app path

Signed-off-by: Prune <[email protected]>

correct patch

Signed-off-by: Prune <[email protected]>

* use Getwd to find the root path for diff commands

Signed-off-by: Prune <[email protected]>

* set dot a default for argo app commands

Signed-off-by: Prune <[email protected]>

* revert default values

Signed-off-by: Prune <[email protected]>

* patch diff in TestNamespacedResourceDiffing

Signed-off-by: Prune <[email protected]>

* patching some diff and sync

Signed-off-by: Prune <[email protected]>

* patch remaining diff in error

Signed-off-by: Prune <[email protected]>

---------

Signed-off-by: Prune <[email protected]>
@blakepettersson
chore(ci): tweak backend filters (argoproj#17134)
0b79445 
The existing backend filters get triggered even on frontend-only or
docs-only changes, which should not be the case. The reason for this
seems to be the fact that each filter line is ORed rather than ANDed.
To remedy this, we put all the filters on the same line.

I tried the filter out in a REPL
(https://runkit.com/blakepettersson/65c3daba99653f0008c74eda). This is
a filter using picomatch (the same library `dorny/paths-filter` uses).

Signed-off-by: Blake Pettersson <[email protected]>
@agaudreault
docs: fix error in toolchain setup (argoproj#17154)
b3d056d 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@ashutosh16
chore(dex): 2.37.0 to 2.38.0 (argoproj#17157)
af562a7 
Signed-off-by: asingh51 <[email protected]>
Co-authored-by: asingh51 <[email protected]>
@shlomitubul
feat: Add support for passing Redis Sentinel username(ACL) and passwo…
391ad13 
…rd (argoproj#17168)

* Add support for passing Sentinel username and password

Signed-off-by: ShlomiTubul <[email protected]>

* fix align with var naming

Signed-off-by: ShlomiTubul <[email protected]>

* fix align with var naming

Signed-off-by: ShlomiTubul <[email protected]>

---------

Signed-off-by: ShlomiTubul <[email protected]>
Co-authored-by: ShlomiTubul <[email protected]>
@gdsoumya
fix: stop initializing deployment informer if dynamic sharding is dis…
33ffc81 
…abled (argoproj#17097)

* fix: stop initializing deployment informer if dynamic sharding is disabled

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: updated sharding cache getter func

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

---------

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
@janschumann @pasha-codefresh
feat: query escape function for notifications (argoproj#16343)
db85659 
Signed-off-by: Jan Schumann <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
adding the basement of the AppProjectfonc
ed54eae
removing some log in sync.go file
7c25257
@dgrizzanti
Update triggers doc to fix typo (argoproj#17185)
de27fc5 
Signed-off-by: David Grizzanti <[email protected]>
@chidambaram27
docs: fixes Template.md targetRevision typo (argoproj#17190)
d486ac7 
* Template.md targetRevision typo fixed

Signed-off-by: Ajay Chidambaram <[email protected]>

* retrigger checks

Signed-off-by: Ajay Chidambaram <[email protected]>

* sign off

Signed-off-by: chidambaram27 <[email protected]>
Signed-off-by: Ajay Chidambaram <[email protected]>

* sign off

Signed-off-by: Ajay Chidambaram <[email protected]>

---------

Signed-off-by: Ajay Chidambaram <[email protected]>
Signed-off-by: chidambaram27 <[email protected]>
@surajyadav1108 @blakepettersson
docs: Private-helm-repo section target added to helm.md (argoproj#16697)
4ff2b99 
* helm-repo

Signed-off-by: Surajyadav <[email protected]>

* Update docs/user-guide/helm.md

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Suraj yadav <[email protected]>

---------

Signed-off-by: Surajyadav <[email protected]>
Signed-off-by: Suraj yadav <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
woehrl01 and others added 3 commits February 14, 2024 10:09
@woehrl01
fix: infer correct shard in statefulset setup (argoproj#17124, argopr…
01cb830 
…oj#17016)  (argoproj#17167)

* fix: infer correct shard in statefulset setup

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix the case if only a single replica

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: resolving pointer on shard compare

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: add readlock for cluster accessor

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: use defer to protect access of 'shard'

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: revert locking in getclusteraccessor

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: handle nil shard case

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: handle any nil shard value as false

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: handle nil case and fix another missing pointer dereference 

Signed-off-by: Lukas Wöhrl <[email protected]>

* revert

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: added tests and fixed some behaviour bugs

Signed-off-by: Lukas Wöhrl <[email protected]>

* test: add test to validate that Shard value is not overriden

Signed-off-by: Lukas Wöhrl <[email protected]>

* fix: added tests and fixe the case when server is changed inside a secret

Signed-off-by: Lukas Wöhrl <[email protected]>

* tests: add test cases for infering the shard logic

Signed-off-by: Lukas Wöhrl <[email protected]>

---------

Signed-off-by: Lukas Wöhrl <[email protected]>
Merge remote-tracking branch 'fork/master' into syncOption
5958c3b
adding new doc for project CRD
f9385cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.