Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method of git() that bypasses cmd parsing. #36

Merged

Conversation

GunnarFarneback
Copy link
Contributor

@GunnarFarneback GunnarFarneback commented Mar 24, 2021

Fixes #30

This PR adds the git(::AbstractVector{<:AbstractString}) method discussed in #30 (comment).

Bonuses:

  • Adds more examples to README.md.
  • Adds a module docstring.
  • Fixes a missing escape in the git docstring.
  • Removes a duplicate test (in fact hijacks it).

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #36 (4365af1) into master (b941046) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           16        19    +3     
=========================================
+ Hits            16        19    +3     
Impacted Files Coverage Δ
src/git_function.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b941046...4365af1. Read the comment docs.

@DilumAluthge
Copy link
Member

Fixes #30?

@GunnarFarneback
Copy link
Contributor Author

I'd say #34 fixed #30, but yes, this adds the second item discussed there. I didn't include a git(::AbstractString) method which would be closer to the removed cmd macro, although that's a small thing to add if desired.

@DilumAluthge DilumAluthge merged commit 46ce401 into JuliaVersionControl:master Mar 24, 2021
@GunnarFarneback GunnarFarneback deleted the bypass_cmd_parsing branch March 24, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support interpolating in git cmd string macro
2 participants