-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use VersionParsing.jl to parse version numbers #19
Comments
Based on https://github.com/stevengj/VersionParsing.jl/blob/master/REQUIRE this would require a mimum Compat 0.62.0. In the process of #21 we are increasing to 0.47.0. Maybe we should increase to 0.62.0 right away? |
No, in general you should list the Compat version that your own code relies upon. The Pkg system is responsible for merging that with the requirements of your dependencies. |
I see, thanks. |
See 932699b. |
Fixed by #21. |
I notice that you have some parsing machinations for handling foreign version numbers via VersionNumber(string). You might try vparse from https://github.com/stevengj/VersionParsing.jl instead.
The text was updated successfully, but these errors were encountered: