Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use VersionParsing.jl to parse version numbers #19

Closed
stevengj opened this issue Mar 19, 2018 · 5 comments
Closed

use VersionParsing.jl to parse version numbers #19

stevengj opened this issue Mar 19, 2018 · 5 comments

Comments

@stevengj
Copy link
Contributor

I notice that you have some parsing machinations for handling foreign version numbers via VersionNumber(string). You might try vparse from https://github.com/stevengj/VersionParsing.jl instead.

@carstenbauer
Copy link
Contributor

carstenbauer commented Nov 7, 2018

Based on https://github.com/stevengj/VersionParsing.jl/blob/master/REQUIRE this would require a mimum Compat 0.62.0. In the process of #21 we are increasing to 0.47.0. Maybe we should increase to 0.62.0 right away?

@stevengj
Copy link
Contributor Author

stevengj commented Nov 7, 2018

No, in general you should list the Compat version that your own code relies upon. The Pkg system is responsible for merging that with the requirements of your dependencies.

@carstenbauer
Copy link
Contributor

I see, thanks.

carstenbauer added a commit to carstenbauer/Git.jl that referenced this issue Nov 7, 2018
@carstenbauer
Copy link
Contributor

See 932699b.

carstenbauer added a commit to carstenbauer/Git.jl that referenced this issue Nov 8, 2018
@ararslan
Copy link
Contributor

ararslan commented Nov 8, 2018

Fixed by #21.

@ararslan ararslan closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants