Extensions do not commit piracy against base package

JuliaTesting · Jul 18, 2023 · 067e6ac · 067e6ac
1 parent 9ae3c19
commit 067e6ac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Aqua.jl b/src/Aqua.jl
@@ -4,6 +4,8 @@ using Base: PkgId, UUID
 using Pkg: Pkg, TOML
 using Test
 
+const JULIA_HAS_EXTENSIONS = isdefined(Base, :get_extension) # introduced in v1.9
+
 try
     findnext('a', "a", 1)
 catch

diff --git a/src/piracy.jl b/src/piracy.jl
@@ -1,5 +1,7 @@
 module Piracy
 
+using Aqua: JULIA_HAS_EXTENSIONS
+
 if VERSION >= v"1.6-"
     using Test: is_in_mods
 else
@@ -160,6 +162,11 @@ end
 function is_pirate(meth::Method; treat_as_own = Union{Function,Type}[])
     method_pkg = Base.PkgId(meth.module)
 
+    # Package extensions behave as the package itself
+    @static if JULIA_HAS_EXTENSIONS
+        method_pkg = get(Base.EXT_PRIMED, method_pkg, method_pkg)
+    end
+
     signature = Base.unwrap_unionall(meth.sig)
 
     # the first parameter in the signature is the function type, and it