Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SampleBuffer #31

Merged
merged 3 commits into from
Oct 11, 2021
Merged

remove SampleBuffer #31

merged 3 commits into from
Oct 11, 2021

Conversation

sjkelly
Copy link
Collaborator

@sjkelly sjkelly commented Oct 5, 2021

This partially addresses #26 and #24. The idea is to go back to a more generic mechanism, and eliminate some sources of issues:

  • on some drivers activate/deactivate` calls do not free memory, we should likely avoid them and always Just Be Fast ( activating/deactivating is an issue on many hardware anyway).
  • Fewer abstraction layers, more suitable for potential SampledSignals integration, or other
  • we no longer need to carry around the MTU, and we leave it up the the user to optimize for latency if desired.

I believe this is likely a more correct fix to #17 and #12.

TODO:

  • test on different hardware
  • check flags
  • update docs
  • will readStreamStatus help?
  • what to do about latency measures?

@sjkelly
Copy link
Collaborator Author

sjkelly commented Oct 6, 2021

This seems to be a minimal fix for the dropped packet issues on the xtrx.

@sjkelly
Copy link
Collaborator Author

sjkelly commented Oct 7, 2021

check flags

Seems dubious, as we already found out, on most platforms. Checking the nread is most robust.

will readStreamStatus help?

This is not universal unfortunately, and an extension of the flags issues

what to do about latency measures?
We make the mtu of a stream transparent to the user now with <Stream>.mtu. Though as noted in some other comments, MTU is only one of the knobs one can turn for latency/throughput optimization.

@sjkelly sjkelly marked this pull request as ready for review October 11, 2021 15:49
@sjkelly sjkelly merged commit 706ff02 into main Oct 11, 2021
@sjkelly sjkelly deleted the sjk/samplebuf1 branch October 22, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant