Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #17, #12, #13
This extends the
SampleBuffer
to be larger in size. It also is now the core primitive to read and write to the device.You will see the following message:
This should probably grow the array rather than shrink? Or make the round up/down an option, and discuss the default.
Several devices do not fully implement the
flags
in Soapy and can struggle to handle fragments. This tries to avoid that situation. Of course the user now need to align with the device time. For example, with this you can't easily say "sample for one second". You will always get "1 second, +/- time aligned to the device". There is some additional complexity kicked up to the user, but I feel this is an acceptable tradeoff for a more robust solution and better real time behavior.Update:
There are a few additional changes here:
activate!
/deactivate!
optional as it is highly timing sensitive, and likely a source of confusion.SampleBuffer
to make it array-like.