Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete useless "not implemented" methods #34

Merged
merged 1 commit into from
May 28, 2024
Merged

delete useless "not implemented" methods #34

merged 1 commit into from
May 28, 2024

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented May 26, 2024

Help the compiler and enable more useful error messages for users.

Help the compiler and enable more useful error messages for users.
@0x0f0f0f
Copy link
Member

cc @shashi

@ChrisRackauckas
Copy link
Member

Yes accept this. It's a violation of our coding standards to not appropriately hit missing dispatch errors since then it doesn't recover properly in contexts like AD

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.36%. Comparing base (b5c0ceb) to head (ca2bf93).
Report is 28 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   42.85%   47.36%   +4.51%     
==========================================
  Files           3        3              
  Lines          28       19       -9     
==========================================
- Hits           12        9       -3     
+ Misses         16       10       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 48ae466 into JuliaSymbolics:master May 28, 2024
5 of 6 checks passed
@nsajko nsajko deleted the not_implemented_method branch May 28, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants