Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inform! for ScoredScheduler. #71

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

MrVPlusOne
Copy link
Contributor

Just a quick fix.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #71 (a585d9e) into master (05e57c2) will decrease coverage by 6.72%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   82.83%   76.10%   -6.73%     
==========================================
  Files          37       33       -4     
  Lines        1311     1285      -26     
==========================================
- Hits         1086      978     -108     
- Misses        225      307      +82     
Impacted Files Coverage Δ
src/EGraphs/Schedulers/scoredscheduler.jl 0.00% <0.00%> (-82.61%) ⬇️
src/EGraphs/eclass.jl 81.48% <ø> (+9.06%) ⬆️
src/EGraphs/saturation/params.jl 0.00% <ø> (ø)
src/Library/algebra.jl 70.37% <ø> (-17.87%) ⬇️
src/rgf.jl 100.00% <ø> (ø)
src/Patterns/patterns_syntax.jl 57.89% <50.00%> (+11.31%) ⬆️
src/EGraphs/saturation/report.jl 90.90% <66.66%> (-9.10%) ⬇️
src/Rules/rule_types.jl 90.69% <81.81%> (+17.01%) ⬆️
src/Rules/rule_dsl.jl 85.41% <84.21%> (-4.06%) ⬇️
src/match.jl 86.04% <86.04%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614e1ee...a585d9e. Read the comment docs.

@0x0f0f0f
Copy link
Member

thx!

@0x0f0f0f 0x0f0f0f merged commit 78a42f2 into JuliaSymbolics:master Aug 31, 2021
0x0f0f0f added a commit that referenced this pull request May 10, 2024
Fix `inform!` for `ScoredScheduler`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants