Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noise in tests, restructure tests, update deps #167

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

0x0f0f0f
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #167 (45eb598) into master (4956519) will decrease coverage by 0.96%.
The diff coverage is 66.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   72.18%   71.22%   -0.96%     
==========================================
  Files          15       15              
  Lines        1330     1317      -13     
==========================================
- Hits          960      938      -22     
- Misses        370      379       +9     
Files Coverage Δ
src/EGraphs/egraph.jl 84.96% <100.00%> (-0.38%) ⬇️
src/Patterns.jl 70.00% <50.00%> (+4.14%) ⬆️
src/Rules.jl 70.17% <66.66%> (-2.24%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0x0f0f0f
Copy link
Member Author

Minimum supported version in CI should be 1.8

@0x0f0f0f
Copy link
Member Author

0x0f0f0f commented Oct 20, 2023

@shashi @ChrisRackauckas it seems that even if MT was deprecated in SU and Symbolics, why do we have to still run tests for downstream? How can we fix this? Shouldn't they be skipped automatically?

@0x0f0f0f 0x0f0f0f merged commit 39349f9 into master Oct 21, 2023
8 of 10 checks passed
0x0f0f0f added a commit that referenced this pull request May 10, 2024
Remove noise in tests, restructure tests, update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants