fixed issues discovered bj JET.jl #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 3, 2022 07:53
They're not used anymore and _isinteger/_isreal would fail because SymbolicUtils is not used anymore
they're not used and they require <ₑ, which is not defined bugs detected by jet
also fallback error at rec_extract had a bug bugs detected by jet
code is slightly faster detected by JET
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 76.64% 76.84% +0.20%
==========================================
Files 15 15
Lines 1400 1382 -18
==========================================
- Hits 1073 1062 -11
+ Misses 327 320 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I guess the failures are not related to this MR, but I still have to check manually, I'll merge after checking. Thanks a lot |
|
fyi, latest 0.6.2 release can now analyse Metatheory.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after patching JET.jl with this not yet merged PR, it's now possible to run
report_package(Metatheory)with Julia 1.8.The current PR fixes most real issues reported by JET. Namely:
something(x)after checkingx !== nothingto get more optimized code.