Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong behavior for the life extraction #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lrnv
Copy link
Member

@lrnv lrnv commented Jul 20, 2024

@rimhajal, maybe the graphs you did for the paper could be added to the docs here. But it needs to be fixed because the implemented behavior was in fact wrong. This PR fixes it and your graph shoul dbe fixed accordingly:

  • When reaching the last line, we should continue to go right
  • When reaching the last column, we should continue to go down
  • The last cell ONLY is up until infinity, so the red arrow should rather be a red "point" inside the last cell, to indicate the end of the trip here.

So the final trip looks like (d means down and r means right) : drdrdrdr OR rdrdrdrd then rrrrrrrrrrr if bottom line reached or dddddddd if last column reached, then eternity in the last cell.

@lrnv lrnv changed the title [Bug] Wrong behaviro fo the life extraction [Bug] Wrong behavior for the life extraction Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.91%. Comparing base (84b2edd) to head (e8dbee7).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Life.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   73.68%   73.91%   +0.22%     
==========================================
  Files           4        4              
  Lines         114      115       +1     
==========================================
+ Hits           84       85       +1     
  Misses         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rimhajal
Copy link
Member

so for someone born in 2000, in 2020 at the last column it would go down?

@lrnv
Copy link
Member Author

lrnv commented Jul 22, 2024

When reaching the last column, go down, but that was already the previous behavior.
When reaching the last line, go right, which was not the previous behavior

@lrnv
Copy link
Member Author

lrnv commented Jul 22, 2024

Hum... Now tahta i see the codecov report showing that the behavior was not tested before and is still not tested, I really wonder which is the best option of the two. For example, which one produces the more sensible life times for elders ? a life expectency that is not too high ? etc...

For the paper, let's make the change to the graphs. For this PR, let's wait until we have proper tests to eventually merge it. Sorry about the noise @rimhajal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants