Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Base.one for StringView #24

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Implement Base.one for StringView #24

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6d24701
Implement Base.one for StringView
mnemnion Mar 3, 2024
1a22be9
Update runtests.jl
mnemnion Mar 5, 2024
9f4766d
Union type signature for Base.one
mnemnion Mar 7, 2024
766348a
Update test/runtests.jl
mnemnion Mar 7, 2024
cbc0e6f
Adds Base.oneunit
mnemnion Mar 7, 2024
db46ed1
Test for oneunit
mnemnion Mar 7, 2024
5ca7fe3
Adds convert for data type of StringView
mnemnion Mar 18, 2024
08034b0
Remove settings.json
mnemnion Mar 18, 2024
3eb4ad9
remove settings.json entirely :/
mnemnion Mar 18, 2024
6423066
Removes Manifest.toml
mnemnion Mar 26, 2024
83796dc
Remove convert, add StringViews{S} constructor
mnemnion Mar 27, 2024
185c620
Remove Manifest.toml
mnemnion Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/StringViews.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ Base.:(==)(s1::StringViewAndSub, s2::StringAndSub) = s2 == s1

Base.typemin(::Type{StringView{Vector{UInt8}}}) = StringView(Vector{UInt8}(undef,0))
Base.typemin(::T) where {T<:StringView} = typemin(T)
Base.one(::T) where {T<:StringView} = typemin(T)
mnemnion marked this conversation as resolved.
Show resolved Hide resolved

if VERSION < v"1.10.0-DEV.1007" # JuliaLang/julia#47880
Base.isvalid(s::DenseStringViewAndSub) = ccall(:u8_isvalid, Int32, (Ptr{UInt8}, Int), s, sizeof(s)) ≠ 0
Expand Down
2 changes: 2 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ end
@test Base.typemin(s) isa StringView{Vector{UInt8}}
@test Base.typemin(s) == ""

@test Base.one(s) == Base.typemin(s) == ""
mnemnion marked this conversation as resolved.
Show resolved Hide resolved

@test isascii(s)
@test !isascii(StringView("fööbār"))

Expand Down
Loading