[deprecation] Remove fix in favor of set_value #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 72.06% 77.01% +4.94%
==========================================
Files 8 8
Lines 469 435 -34
==========================================
- Hits 338 335 -3
+ Misses 131 100 -31
Continue to review full report at Codecov.
|
| @@ -115,44 +74,3 @@ function parameter_by_name(model::Model, name::String) | |||
| end | |||
| return nothing | |||
| end | |||
|
|
|||
| JuMP.has_lower_bound(p::ParameterRef) = false | |||
There was a problem hiding this comment.
Are the errors for missing methods very clear about what the user should do?
There was a problem hiding this comment.
It will throw a method error. This is not defined.
There was a problem hiding this comment.
We don't define has_lower_bound on nonlinear parameters, for example.
There was a problem hiding this comment.
julia> has_lower_bound(p)
ERROR: MethodError: no method matching has_lower_bound(::ParameterRef)
Closest candidates are:
has_lower_bound(::VariableRef) at /Users/oscar/.julia/packages/JuMP/y5vgk/src/variables.jl:352
Stacktrace:
[1] top-level scope at REPL[9]:1There was a problem hiding this comment.
I see, well ok. Lets got for it and think more if people get confused at some point.
|
Looks like my merge didn't work. Let me try again. |
JuMP's Nonlinear parameters use
set_valueandvalue: https://jump.dev/JuMP.jl/stable/nlp/#Nonlinear-ParametersWe should follow that.