VIF and GVIF #300
Merged
VIF and GVIF #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
palday
commented
Sep 6, 2023
•
palday
commented
- still needs more extensive tests, but I haven't had a chance to see what it would take to fake something reasonable
nalimilan
reviewed
Sep 7, 2023
nalimilan
reviewed
Sep 10, 2023
|
Also there seem to remain a few uncovered lines (apart from the |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
reviewed
Sep 10, 2023
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Sep 10, 2023
kleinschmidt
approved these changes
Sep 11, 2023
palday
commented
Sep 12, 2023
palday
commented
Sep 12, 2023
nalimilan
reviewed
Sep 12, 2023
test/vif.jl
Outdated
| @@ -44,6 +44,10 @@ StatsModels.formula(model::Duncan) = model.formula | |||
| @test vif(MyRegressionModel3()) ≈ [1, 1] | |||
| end | |||
|
|
|||
| # Reference values from | |||
| # https://github.com/palday/MixedModelsExtras.jl/blob/6db061cb856301c04b978101d4c53b90c890715b/test/vif.jl | |||
There was a problem hiding this comment.
Can you copy the relevant parts from that file instead? It's weird to rely on MixedModelsExtras for that, especially if this PR is supposed to provide the same features more upstream.
There was a problem hiding this comment.
I mean, the relevant parts of that file are just the reference values. I'm planning on writing out the R code to do it again, which is why I hadn't merged this PR yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.