Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test mean of empty Union{}-eltyped collections #40

Merged
merged 2 commits into from
May 27, 2020
Merged

Test mean of empty Union{}-eltyped collections #40

merged 2 commits into from
May 27, 2020

Conversation

tkf
Copy link
Contributor

@tkf tkf commented May 15, 2020

tkf
tkf commented May 15, 2020
View reviewed changes
test/runtests.jl Outdated
@@ -120,6 +120,10 @@ end
@test_throws MethodError mean([])
@test_throws MethodError mean(skipmissing([]))
@test_throws ArgumentError mean((1 for i in 2:1))
if VERSION >= v"1.6"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bound has to be updated once JuliaLang/julia#35843 is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's merged now! :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping :)

@tkf tkf mentioned this pull request May 15, 2020
Merged
@tkf tkf marked this pull request as ready for review May 27, 2020 16:42
@nalimilan nalimilan merged commit 4069cd5 into JuliaStats:master May 27, 2020
@nalimilan
Copy link
Member

Thanks!

@tkf tkf deleted the empty-mean branch May 27, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @nalimilan