Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #82

Merged
merged 5 commits into from
May 7, 2020
Merged

Update Readme.md #82

merged 5 commits into from
May 7, 2020

Conversation

PaulSoderlind
Copy link
Contributor

to include information on what the UnivariateKDE object contains (with a very basic example of how to plot)

@tpapp
Copy link
Collaborator

tpapp commented May 7, 2020

Thanks for doing this (cf #72). Can you please add the same explanation to the bivariate part?

@PaulSoderlind
Copy link
Contributor Author

done

Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I had a review in progress but forgot to submit it, so you did not see the other changes I requested. Specifically, I don't think we should put plotting commands in the README.

README.md Outdated Show resolved Hide resolved
PaulSoderlind and others added 2 commits May 7, 2020 14:39
Co-authored-by: Tamas K. Papp <[email protected]>
deleted also the contour plot
@tpapp
Copy link
Collaborator

tpapp commented May 7, 2020

Thanks for the PR and all the changes!

@tpapp tpapp merged commit e9d0c1b into JuliaStats:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants