Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrappers of uppercase libmklsparse functions #51

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Sep 16, 2024

mkl_spblas.h header contains definitions both for lower- and uppercase versions of each "classical" sparse BLAS routine.
There is no reason to wrap both versions, and MKLSparse.jl only uses the lowercase ones.
Removing uppercase defs halves the size of libmklsparse.jl.

Also, output_ignorelist of the wrapper.jl script is optimized by converting explicit strings to regexes.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.38%. Comparing base (80572fa) to head (4f2106c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   24.86%   33.38%   +8.51%     
==========================================
  Files           7        7              
  Lines        1693     1261     -432     
==========================================
  Hits          421      421              
+ Misses       1272      840     -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison merged commit beb40be into master Sep 16, 2024
10 checks passed
@amontoison amontoison deleted the alyst/remove_ucase_wrappers branch September 16, 2024 21:09
@alyst
Copy link
Contributor Author

alyst commented Sep 16, 2024

@amontoison That was fast, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants