Remove unnecessary eltype checks of preconditioners #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't even used and should not be expected to be defined. Matrix-free preconditioners, like geometric multigrid, do not necessarily have a sense of what eltype is.
ChrisRackauckas
added a commit
to ChrisRackauckas/IncompleteLU.jl
that referenced
this pull request
Jan 9, 2022
Honestly this shouldn't be required, but for some reason Krylov.jl wants to check the eltype of a preconditioner. I'm telling them not to ask for potentially undefined quantities here: JuliaSmoothOptimizers/Krylov.jl#477, but in the meantime this is required for compatibility.
|
Thanks @ChrisRackauckas |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't even used and should not be expected to be defined. Matrix-free preconditioners, like geometric multigrid, do not necessarily have a sense of what eltype is.