Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for err return #88

Closed
wants to merge 1 commit into from
Closed

Conversation

vtjnash
Copy link

@vtjnash vtjnash commented Dec 21, 2019

Pass a reference to the err location instead of the value.

Pass a reference to the `err` location instead of the value.
@coveralls
Copy link

coveralls commented Dec 21, 2019

Pull Request Test Coverage Report for Build 432

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 99.502%

Files with Coverage Reduction New Missed Lines %
src\ampl_model.jl 1 99.5%
Totals Coverage Status
Change from base Build 428: 0.05%
Covered Lines: 1000
Relevant Lines: 1005

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 21, 2019

Pull Request Test Coverage Report for Build 432

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 99.502%

Files with Coverage Reduction New Missed Lines %
src\ampl_model.jl 1 99.5%
Totals Coverage Status
Change from base Build 428: 0.05%
Covered Lines: 1400
Relevant Lines: 1407

💛 - Coveralls

@dpo
Copy link
Member

dpo commented Dec 22, 2019

Wasn't it passing a reference already? Also it seems strange that there are failures with this change.

@vtjnash
Copy link
Author

vtjnash commented Dec 22, 2019

It was not. It was passing the value of the variable err, a constant set to success? Why is it surprising that failing to check for errors would have resulted in CI that used to mostly pass? I found this problem because it was often failing when I ran the tests locally. I'm surprised that a lot more CI workers passed than I expected. I don't intend to fix this package, just wanted to bring awareness to the problem.

dpo added a commit that referenced this pull request Dec 24, 2019
@dpo dpo closed this in #89 Dec 25, 2019
dpo added a commit that referenced this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants