-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMU Lie Group pre-integration factor #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Here are a few quick comments, I will be looking into it more deeply.
end | ||
|
||
# right Jacobian | ||
function Jr(M::IMUDeltaGroup, X; order=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a matrix form of differential_exp_argument
from ManifoldDiff.jl. More specifically, differential_exp_argument_lie_approx!
. Having it in matrix form makes sense though for covariance propagation, which can be done using matrix multiplication instead of repeated calls to differential_exp_argument_lie_approx!
.
A slightly off-topic comment. What I'd consider natural (but haven't seen that anywhere yet) for state estimation:
There is still some room for arbitrary choices here and there (left vs right-invariant errors and much more) but it would be a decent framework to compare and develop different Kalman filter variants and to a degree also more general particle filters. It looks like most people don't care too much about (2) and then choices they make in (3) and (4) feel more arbitrary then they really are, or are incorrect. Slightly more on-topic, inclusion of |
Hi Mateusz,
I like this a lot, and think this is the way to go. I have not seen geodesic IMU integration models either...
Our stuff explicitly does not follow the standard Kalman assumptions (linear, time-invariant). We are working to write down IMU integration models purely as continuous domain equations only.
Yep, I agree That said, the assumptions in much of the IMU preintegration literature is that multiplying IMU bias by
integrating one set of imu measurements for all possible noises will produce one fiber. Taking all possible imu measurements and noise combinations would produce the full fiber bundle (i.e. range space). |
Hi Dehann,
Yes, that's correct. One of my current projects is extending Manifolds.jl to support such fiber bundles. |
This is starting to work but needs more testing on covariance propagation and the bias correction Jacobian. Will come back to that in separate PRs when time permits. |
Implements https://hal.science/hal-02183498/document