-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for more recent Julia versions #634
Conversation
rdeits
commented
May 8, 2023
- Require Julia 1.6 (the current LTS) as the minimum Julia version
- Require Rotations.jl 1.1 and rename UnitQuaternion -> QuatRotation to match
- Update all Manifest.toml files to the new format and re-generate them on the latest Julia release
- Test Julia 1.6 and the latest release on CI
Hi Robin! Thanks for taking the time to do this. FYI, I have an open MR for the rotations: #629. It looks very similar to your changes, except perhaps for quat = convert(QuatRotation{T}, rot)
w, x, y, z = Rotations.params(quat) which I remember having to do at that time to retrieve On a related note, I've created a new release on my personal fork just yesterday: ferrolho/[email protected]. Maybe it can serve as inspiration for what the next release of the Julia Robotics repo could be. I'm happy to help taking this through! |
Ah, nice, I prefer your |
skip symbolics notebook until it becomes compatible with quaternions
Remaining CI error can be fixed with #636 |
stop using pyplot in favour of the default (GR) in notebook 4
Project.toml
Outdated
@@ -1,6 +1,6 @@ | |||
name = "RigidBodyDynamics" | |||
uuid = "366cf18f-59d5-5db9-a4de-86a9f6786172" | |||
version = "2.3.2" | |||
version = "2.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could increment it to 2.4.0 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge from my end (I don't have permissions to do it).