Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTING] for orphaned FGs #519

Merged
merged 5 commits into from
Jan 16, 2020
Merged

[TESTING] for orphaned FGs #519

merged 5 commits into from
Jan 16, 2020

Conversation

dehann
Copy link
Member

@dehann dehann commented Jan 5, 2020 •
edited
Loading

Fixes #518

@dehann dehann added this to the v0.8.4 milestone Jan 5, 2020
@dehann dehann changed the title test for orphaned FGs [TESTING] for orphaned FGs Jan 9, 2020
@dehann dehann added the testing label Jan 9, 2020
@Affie
Bugfix for orphaned trees to start from all roots (#533)
18ad1a8 
Merged master and bugfix shows too many changes, so I'm merging to branch so you can compare to master
@Affie
Copy link
Member

Affie commented Jan 15, 2020 •
edited
Loading

At least a partial fix for #518 see #518 (comment)

@Affie
Copy link
Member

Affie commented Jan 15, 2020

@dehann Test just runs code, so still to do is to add actual tests. It looks correct though.

@codecov-io
Copy link

codecov-io commented Jan 15, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@18ad1a8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #519   +/-   ##
=========================================
  Coverage          ?   47.52%           
=========================================
  Files             ?       30           
  Lines             ?     3918           
  Branches          ?        0           
=========================================
  Hits              ?     1862           
  Misses            ?     2056           
  Partials          ?        0
Impacted Files Coverage Δ
src/CanonicalGraphExamples.jl 69.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ad1a8...dd2bc2b. Read the comment docs.

@dehann dehann marked this pull request as ready for review January 16, 2020 13:36
@dehann
Copy link
Member Author

dehann commented Jan 16, 2020

Hi, thanks! I expanded and added more concrete testing, will merge when Travis tests run through.

@dehann dehann mentioned this pull request Jan 16, 2020
Closed
@dehann dehann merged commit d209777 into master Jan 16, 2020
@dehann dehann deleted the maint/1Q20/orphanedfg branch June 15, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bayes junction tree clique state machine enhancement inference testing user experience
Projects
None yet
Milestone
v0.8.4
Development

Successfully merging this pull request may close these issues.

Can you solve multiple orphaned graphs?
3 participants
@dehann @Affie @codecov-io