Default getSample methods for group manifolds

[Affie]

No description provided.

[codecov]

Codecov Report

Merging #1439 (f80fa36) into master (adbe12a) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head f80fa36 differs from pull request most recent head 75b4d88. Consider uploading reports for the commit 75b4d88 to get more accurate results

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   77.18%   77.04%   -0.15%     
==========================================
  Files          67       67              
  Lines        4940     4948       +8     
==========================================
- Hits         3813     3812       -1     
- Misses       1127     1136       +9     

Impacted Files	Coverage Δ
src/ManifoldSampling.jl	66.66% <ø> (-24.25%)	⬇️
src/NumericalCalculations.jl	91.57% <0.00%> (-1.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbe12a...75b4d88. Read the comment docs.

[dehann]

From the call today, two comments came up:

• Check hasproperty for .Z and give good warning for user to easily understand
• Lets use convention of field .Z as the automated field for both non-parametric and parametric (non-restrictive),

xref #1441

Added to requirements wiki: https://github.com/JuliaRobotics/Caesar.jl/wiki/High-Level-Requirements

[Affie]

@dehann, comments implemented.

[Affie]

I don't think this is a breaking change, should it not be in v0.25.6?

[dehann]

perhaps we should standardize with API

function getMeasurement(::AbstractFactor) ...

to return the field .Z etc. This can then also be used the existing function getMeasurementParametric which extracts the mean and covariance of the same .Z for parametric solves?