Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test manifold approxDeconv #1380

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

Affie
Copy link
Member

@Affie Affie commented Sep 9, 2021

close #1374

Note: only for measurements as tangent vectors

@Affie Affie self-assigned this Sep 9, 2021
@Affie Affie added this to the v0.25.0 milestone Sep 9, 2021
@Affie Affie marked this pull request as ready for review September 9, 2021 16:50
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1380 (4275fad) into master (e8a6110) will increase coverage by 0.08%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   76.39%   76.48%   +0.08%     
==========================================
  Files          67       67              
  Lines        4906     4920      +14     
==========================================
+ Hits         3748     3763      +15     
+ Misses       1158     1157       -1     
Impacted Files Coverage Δ
src/NumericalCalculations.jl 92.70% <92.85%> (+0.02%) ⬆️
src/DeconvUtils.jl 62.50% <100.00%> (+4.16%) ⬆️
src/services/CalcFactor.jl 91.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a6110...4275fad. Read the comment docs.

@Affie Affie merged commit c3c8d5f into master Sep 9, 2021
@dehann
Copy link
Member

dehann commented Sep 10, 2021

Note: only for measurements as tangent vectors

thanks @Affie , i added a link to requirements: https://github.com/JuliaRobotics/Caesar.jl/wiki/High-Level-Requirements

@dehann dehann deleted the 21Q3/fix/mani_deconv_1374 branch December 16, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_solveLambdaNumeric for AbstractManifoldMinimize does not work for deconv
2 participants