Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perhaps consolidate to single Mixture, not separate Prior/Relative #933

Closed
dehann opened this issue Sep 30, 2020 · 0 comments · Fixed by #956
Closed

Perhaps consolidate to single Mixture, not separate Prior/Relative #933

dehann opened this issue Sep 30, 2020 · 0 comments · Fixed by #956
Labels
API factors inference mixture parametric solve refactoring serialization standardization types
Milestone
v0.16.0

Comments

@dehann
Copy link
Member

dehann commented Sep 30, 2020 •
edited
Loading

It might be possible to just use and serialize Mixture{N,F,S,T} rather than the current separate MixturePrior and MixtureRelative.

  • The current convolutional code already has a common getSample and evalSpecial dispatch method implementation,
  • The PackedMixtureRelative method looks to be working,

Also keep in mind that specialSampler pass through still needs to be addressed (see #927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API factors inference mixture parametric solve refactoring serialization standardization types
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

standardize Mixture, fix #933 JuliaRobotics/IncrementalInference.jl
1 participant
@dehann