Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Pass variables to factor evaluation so that we can use variable data? #784

Closed
GearsAD opened this issue Jul 17, 2020 · 3 comments

Comments

@GearsAD
Copy link
Collaborator

GearsAD commented Jul 17, 2020

I'd like to use the data from variables in the factor evaluation, e.g. Radar data. I think we should pass down the variables into the factor evaluation, so that I could potentially use smallData or bigData.


EDIT

DF, punchline: #784 (comment)


DF edit, predominant design discussion over in #783 -- can use this issue once a decision has been made there on how to split manifest and user-meta-data requirement.

user desire for more "metadata" in a variable: #783 (comment) -- i.e additional data format and contents from end user not know at design time.

@dehann
Copy link
Member

dehann commented Jul 19, 2020

moving to v0.15.0 as more realistic. Hopefully can make 783 decision by v0.14.0

@dehann dehann added the decision label Aug 3, 2020
@dehann
Copy link
Member

dehann commented Aug 3, 2020

resolved with discussion around and following #783 (comment)

@dehann
Copy link
Member

dehann commented Feb 6, 2021

Punchline is to use the new CalcFactor approach, and hopefully stable API defined in v0.21. See #467 as relatively well linked issue discussion on what the API should be. All metadata (variables, smalldata, entry=>data, etc.) are available through the CalcFactor approach. This is both during residual factor evaluation and getSample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants