Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "ManifoldsBase" to "0.11" #76

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ManifoldsBase package from 0.10 to 0.10, 0.11.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #76 (6313988) into master (8f59d87) will not change coverage.
The diff coverage is n/a.

❗ Current head 6313988 differs from pull request most recent head 36003e4. Consider uploading reports for the commit 36003e4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   33.60%   33.60%           
=======================================
  Files          13       13           
  Lines         494      494           
=======================================
  Hits          166      166           
  Misses        328      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f59d87...36003e4. Read the comment docs.

@dehann dehann merged commit 7c11929 into master May 21, 2021
@dehann dehann added this to the v0.3.4 milestone May 21, 2021
@mateuszbaran
Copy link
Collaborator

Merging this was a bit premature, we've cleaned up our interface a bit in ManifoldsBase 0.11 (for example Manifold was renamed to AbstractManifold). Currently we're finishing a compatible version of Manifolds.jl (JuliaManifolds/Manifolds.jl#325). Once this is done I can help you with upgrading but it should boil down to renaming:

  • Manifold to AbstractManifold,
  • zero_tangent_vector to zero_vector and zero_tangent_vector! to zero_vector!,
  • check_manifold_point to check_point,
  • check_tangent_vector to check_vector (and it has a bit different interface),
  • is_tangent_vector to is_vector,
  • is_manifold_point to is_point,
  • MPoint to AbstractManifoldPoint.

There are also a few smaller changes but you shouldn't notice them.

@dehann dehann deleted the compathelper/new_version/2021-05-20-00-18-39-676-2496104871 branch June 29, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants