Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Revise v3.5.8 #95096

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 295af30f-e4ad-537b-8983-00126c2a3abe
Repo: https://github.com/timholy/Revise.jl.git
Tree: 62fbfbbed77a20e9390c4f02219cb3b11d21708d

Registrator tree SHA: 1ede4be248caa0b367cc8ebce8a0c76cb916c479
JuliaRegistrator referenced this pull request in timholy/Revise.jl Nov 10, 2023
* Filter out more doc signature expressions

Revise extracts the documented expression and puts that before the full
doc expression in the revision queue. E.g. in `"docs" f(x) = x` there
will be a revision of `f(x) = x` followed by a revision of the full
expresion (`"docs" f(x) = x`). However, in many cases a docstring is
only attached to a signature (not a function body/struct definition,
etc.) and in this case the revision of the signature is not needed.

Revise already filters out the base case, `"docs" f(x)`. This patch
extends this filtering to also apply to `where`-clauses such as e.g.
`"docs" f(x::T) where T <: Integer`.

Concretely, this patch fixes #735, i.e. revising doc expressions where
the signature doesn't lower without the context of the doc macro. As a
bonus, slightly less work has to be done for e.g. `"docs" f(x::T) where
T` since this is also filtered out.

* Set version to 3.5.8.
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 8a3d7e4 into master Nov 10, 2023
14 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-revise-295af30f-v3.5.8-0f5c25da1d branch November 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants