Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move three existing packages under the SpeciesDistributionToolkit monorepo #73409

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

tpoisot
Copy link
Contributor

@tpoisot tpoisot commented Dec 3, 2022

This updates G/GBIF/Package.toml to point to a subdir within a new repo. I will open a PR for a new release after this one is merged?

@giordano
Copy link
Member

giordano commented Dec 4, 2022

Are all previous versions of this package available in the history of the new repository?

@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 6, 2022

No, only the new versions will. There's still a repo with all the previous releases/history (but this repo won't be updated after the move to the new one).

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this change breaks the package

@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 6, 2022

Yes - I'd really appreciate some guidance about how to handle the situation then, especially because I'll need to reproduce the process for two more.

@t-bltg
Copy link
Contributor

t-bltg commented Dec 6, 2022

I did this for Plots, moving RecipesBase.jl and RecipesPipeline.jl in Plots.jl subdirs, with the procedure followed detailed in JuliaPlots/Plots.jl#4419 (comment) (especially the sanity check).

EDIT: if you're working with PRs, don't squash the commits on merging the PR to master as I did JuliaPlots/Plots.jl#4441 😅

@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 8, 2022

@t-bltg thanks for the feedback - I've done a bit of work since the move, do you think the git-filter-repo recipe would work still?

@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 9, 2022

@giordano I have applied the fix suggested by @t-bltg -- here is the output of the sanity check for the three packages affected by the change.

GBIF
0.1.4 found
0.2.0 found
0.2.1 found
0.2.2 found
0.2.3 found
0.2.4 found
0.3.0 found
0.3.1 found
0.3.2 found
0.3.3 found
Fauxcurrences
0.0.1 found
SimpleSDMLayers
0.0.1 found
0.1.0 found
0.2.0 found
0.2.1 found
0.2.2 found
0.3.0 found
0.3.1 found
0.3.2 found
0.3.3 found
0.3.4 found
0.3.5 found
0.3.6 found
0.4.0 found
0.4.1 found
0.4.2 found
0.4.3 found
0.4.4 found
0.4.5 found
0.4.6 found
0.4.7 found
0.4.8 found
0.5.0 found
0.6.0 found
0.7.0 found
0.8.0 found
0.8.1 found
0.8.2 found
0.8.3 found

@tpoisot tpoisot changed the title Move GBIF.jl to a new repo Move three existing packages under the SpeciesDistributionToolkit monorepo Dec 9, 2022
@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 9, 2022

This isn't ready to be merged yet, I am waiting for the tests to run.

@tpoisot
Copy link
Contributor Author

tpoisot commented Dec 9, 2022

@giordano all clear on my side, but please let me know if you see additional steps

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this branch I was now able to install those packages:

(jl_BuvnMt) pkg> st
Status `/tmp/jl_BuvnMt/Project.toml`
  [a2d61402] Fauxcurrences v0.0.1
  [ee291a33] GBIF v0.3.3
  [2c645270] SimpleSDMLayers v0.8.3

Thanks for doing it! 👍

@giordano giordano merged commit fdc61a0 into JuliaRegistries:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants