Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CBFV v0.1.0 #58480

Merged
merged 1 commit into from
Apr 20, 2022
Merged

New package: CBFV v0.1.0 #58480

merged 1 commit into from
Apr 20, 2022

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: e079e57c-70e8-4f61-a09b-990e8be4fed3
Repo: https://github.com/JuliaMatSci/CBFV.jl.git
Tree: 81fba898c4e80b8549f5348b74d08197a04afc85

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long
  • Package name similar to 3 existing packages.
    1. Similar to CBLS. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    2. Similar to CBOR. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    3. Similar to CSV. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@stefanbringuier
Copy link

The CBFV name is most appropriate for this package given it is based on the python implementation named CBFV and is available under the Python Package Index (PyPI) under the package name CBFV.

@StefanKarpinski
Copy link
Contributor

Seems reasonable to me. But will allow others to chime in. Sorry for the additional delay but we should allow some other opinions (you posted on Friday, but was a long holiday weekend and I didn't see it until today).

@giordano giordano merged commit 2042377 into master Apr 20, 2022
@giordano giordano deleted the registrator/cbfv/e079e57c/v0.1.0 branch April 20, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants