New version: Manifolds v0.4.18 #32525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Mar 22, 2021
JuliaRegistrator
commented
- Registering package: Manifolds
- Repository: https://github.com/JuliaManifolds/Manifolds.jl
- Created by: @sethaxen
- Version: v0.4.18
- Commit: b3d77872303b39511807f221be2b12e26c1d942a
- Reviewed by: @sethaxen
- Reference: JuliaManifolds/Manifolds.jl@b3d7787#commitcomment-48535859
UUID: 1cead3c2-87b3-11e9-0ccd-23c62b72b94e Repo: https://github.com/JuliaManifolds/Manifolds.jl.git Tree: f719da086e226ae71384dfb15b10d932dc3edf9c Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
JuliaRegistrator
referenced
this pull request
in JuliaManifolds/Manifolds.jl
Mar 22, 2021
* Add group_log! default implementation * Add solver for inverting geodesic * Add implementation of 2x2 exp * Add GeneralLinear * Move docstring * Rename file * Add ApproximateInverseRetraction * Add NLsolve to extras * Run formatter * Revert "Add implementation of 2x2 exp" This reverts commit d0daf0e. * Used StaticArrays's 2x2 exp * Add section to docs * Remove GLInvariantMetric The general case is domain-specific and difficult to generalize for complex matrices. * Don't return twice * Use correct signature for inner * Add mul!_safe * Add realify and complexify * Add utility for checking normality * Use existing methods * Generalize (un)realify * Don't overwrite method * Reimplement logarithm * Use correct tangent space representation * Compute more efficiently for normal matrix. * Add inplace log_safe! * Make General Linear an embedded manifold * Add more projection methods * Add NLsolve to tests * Add tests for general linear group * Test complex general linear group * Run JuliaFormatter * Add special linear group * Remove unnecessary overload * Use actions of differentials This are no-ops, but they are essentially cost-free and make the function still work if we ever change conventions. * Error for log between disconnected submanifolds * More efficiently adjust sign of determinant * Implement projections on SL(n) * Fix check * Use correct signature * Revert "Add inplace log_safe!" This reverts commit 2ec98d3. * Fix calling project! * Copy if needs no projection * Remove unnecessary re-definition * Add log_safe! * Use log_safe! and disallow Number * Use log_safe! * Remove unused allocation * Override Euclidean distance * Increase tolerance of checks * Decrease size of matrix * Resolve ambiguities * Restrict type definition of group_log! * Run formatter * Add back missing type params * Increase tolerance for log_safe! tests * Resolve ambiguities * Move utils tests * Move configurable parameters to struct * Add tests for ApproximateInverseRetraction * Add docstrings * Remove unnecessary types * Refactor to use NLsolveInverseRetraction * Fixes and improvements to docstrings * Fix docstring * Make nlsolve function non-allocating * Make tests more reliably pass * Run formatter * Add TODO note on future approach * Increment allowed ambiguities PowerManifold's overload of inverse_retract causes ambiguities with new NLsolveInverseRetraction. * More generally project to U(n) x S^+ * Add additional to-do * Simplify log logic * Add tests for isnormal * Add tests for (un)realify * Fix tests * Decrease tolerance of matrix log tests * Run tests on GL+ * Test exp and log * Test remaining cases * Run formatter * Use references in docstring * Concretely type kwargs * Apply suggestions from code review Co-authored-by: Ronny Bergmann <[email protected]> * Use correct inheritance * Use backticks for equations instead of dollar signs * Simplify * Rewrap docstring * Use loops instead of broadcast * Test OutOfInjectivityRadiusError thrown * Make matrix exactly hermitian * Add tests for default metric dispatch * Run formatter * Remove todo * Increment version number Co-authored-by: Ronny Bergmann <[email protected]>
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.