Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Oceananigans v0.43.0 #23319

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

Fixes a bug in TwoDimensionalLeith (PR #1073, issue #1034). Previously tests were being skipped due to extreme slowness. Now we run tests on GPU (but not CPU, where the closure is much slower to compile).

Rewrites the interface for "scheduling" output and diagnostics (PR #1070). Previously output and diagnostics were usually scheduled by specifying either time_interval or iteration_interval kwargs in the constrcutor for the object in question. Now, the relevant kwarg is called schedule and takes a callable AbstractSchedule object (or any user-defined function func that returns true or false depending on the single argument func(model)). This design is more flexible and extensible, and also simplifies underlying code. Four schedules are provided:

TimeInterval(interval)
IterationInterval(interval)
WallTimeInterval(interval)
AveragedTimeInterval(interval; window=interval, stride=1) (for time-averaging output).
Breaking changes:

Output writers and diagnostics no longer have the keyword arguments time_interval or iteration_interval. The most commonly-used features that are affected are JLD2OutputWriter, NetCDFOutputWriter, and Checkpointer. JLD2OutputWriter and NetCDFOutputWriter no longer have the kwargs time_averaging_window and time_averaging_stride. The specific syntax changes are:

time_interval=T becomes schedule=TimeInterval(T)
iteration_interval=I becomes schedule=IterationInterval(I)
time_interval=T, time_averaging_window=W becomes schedule=AveragedTimeInterval(T, window=W).

UUID: 9e8cae18-63c1-5223-a75c-80ca9d6e9a09
Repo: https://github.com/CliMA/Oceananigans.jl.git
Tree: 057c19a561e61a3e86ab36f3ead3819e2edb001b

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@github-actions github-actions bot merged commit 3794f45 into master Oct 20, 2020
@github-actions github-actions bot deleted the registrator/oceananigans/9e8cae18/v0.43.0 branch October 20, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant