-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove IIF v0.5.5, #230
remove IIF v0.5.5, #230
Conversation
trying to fix JuliaLang/Pkg.jl#1169, follows JuliaRegistries#49
Does this fix your problem? Can we just add compatibility constraints on this version instead (if that's the problem)? |
V0.5.5 is equivalent to v0.5.6, which just adds the compatibility constraints — so as long as we can skip v0.5.5 and go to 0.5.6 it should be good to go. |
Now I'm not sure if removing v0.5.5 does fix the assertion error. I'm trying to manually change the registry at Can I just change the |
No, this is the source of truth now. |
Alright thanks, let me fuss with my local |
cc @tonioteran for status updates on installing IncrementalInference |
How can this error be reproduced? |
Just try installing IIF in a new environment. ]add IncrementalInference |
That works for me though. |
Oh wow, okay. Two people tried it yesterday and failed. Are you perhaps on Pkg#master? |
Oh, I was on JuliaLang/julia#30954 Does this PR actually fix the issue? It doesn't for me. |
At first it wasn't clear to me whether this PR fixed the issue (just removed all traces of v0.5.5). Now that I am able to test with local Registry, I don't think the PR is quite right yet. I'll fix it soon -- been unusually busy the last couple days, sorry! Thanks again for the info and help! |
Hi, @fredrikekre, I need some more help if possible please. I finally got back to this: trying to fix the registry regarding a p0 != p1 error. I tried modifying the My suggested solution now is to completely scrap v0.5.5 and v0.5.6 from the registry, and redo a new registration with compat requirements defined. Is that a workable solution? Please double check my suggested changes here. |
I think it is better to try to impose bounds on the existing releases. I'll have a look later. |
okay, thanks -- sorry to keep bothering you with this! |
Here is my latest attempt to fix the compat requirements:
and the resulting output on my computer: dehann@mrg-galago-01:-.julia/environments/fix1169
$ ls
dehann@mrg-galago-01:-.julia/environments/fix1169
$ julia -O3
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.0.3 (2018-12-18)
_/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release
|__/ |
(v1.0) pkg> activate .
(fix1169) pkg> add IncrementalInference
Updating registry at `~/.julia/registries/General`
┌ Warning: Some registries failed to update:
│ — `~/.julia/registries/General` — registry dirty
└ @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:157
Resolving package versions...
ERROR: AssertionError: p0 ≠ p1
Stacktrace:
[1] Pkg.GraphType.Graph(::Dict{Base.UUID,Set{VersionNumber}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Base.UUID}}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Pkg.Types.VersionSpec}}}, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}, ::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/GraphType.jl:315
[2] deps_graph(::Pkg.Types.Context, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:307
[3] resolve_versions!(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}, ::Nothing) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:371
[4] resolve_versions! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:316 [inlined]
[5] #add_or_develop#62(::Array{Base.UUID,1}, ::Symbol, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:1201
[6] #add_or_develop at ./none:0 [inlined]
[7] #add_or_develop#13(::Symbol, ::Bool, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:64
[8] (::getfield(Pkg.API, Symbol("#kw##add_or_develop")))(::NamedTuple{(:mode,),Tuple{Symbol}}, ::typeof(Pkg.API.add_or_develop), ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at ./none:0
[9] do_add!(::Dict{Symbol,Any}, ::Array{Pkg.Types.PackageSpec,1}, ::Dict{Symbol,Any}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:709
[10] #invokelatest#1(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:697
[11] invokelatest(::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:696
[12] do_cmd!(::Pkg.REPLMode.PkgCommand, ::REPL.LineEditREPL) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:603
[13] #do_cmd#33(::Bool, ::Function, ::REPL.LineEditREPL, ::String) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:577
[14] do_cmd at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:573 [inlined]
[15] (::getfield(Pkg.REPLMode, Symbol("##50#53")){REPL.LineEditREPL,REPL.LineEdit.Prompt})(::REPL.LineEdit.MIState, ::Base.GenericIOBuffer{Array{UInt8,1}}, ::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:923
[16] #invokelatest#1 at ./essentials.jl:697 [inlined]
[17] invokelatest at ./essentials.jl:696 [inlined]
[18] run_interface(::REPL.Terminals.TextTerminal, ::REPL.LineEdit.ModalInterface, ::REPL.LineEdit.MIState) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/LineEdit.jl:2273
[19] run_frontend(::REPL.LineEditREPL, ::REPL.REPLBackendRef) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:1034
[20] run_repl(::REPL.AbstractREPL, ::Any) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:191
[21] (::getfield(Base, Symbol("##718#720")){Bool,Bool,Bool,Bool})(::Module) at ./client.jl:355
[22] #invokelatest#1 at ./essentials.jl:697 [inlined]
[23] invokelatest at ./essentials.jl:696 [inlined]
[24] run_main_repl(::Bool, ::Bool, ::Bool, ::Bool, ::Bool) at ./client.jl:339
[25] exec_options(::Base.JLOptions) at ./client.jl:277
[26] _start() at ./client.jl:425
(fix1169) pkg> |
Hi @fredrikekre , thank you very much! Sorry I didn't get there by myself, but things make more sense to me now. I was working on the assumption that pre-existing versions should have still worked -- but see now that the new Registrator method requires all versions relating to Julia 0.7+ to have Either way, thank you again! I should be able to figure the tomls in registry out better in the future. |
In case anybody else arrives here due to I think this IncrementalInference package would have failed in a similar way based on existing version Thanks again for the Julia guys' help! I was a little lost at first, and the fix turned out to be easy, as long as you know what had happened. |
Trying to fix JuliaLang/Pkg.jl#1169, from a suggestion -- cc @KristofferC (Thanks!)
follows: