Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit LLVM version to the one supported by Julia #11224

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

vchuravy
Copy link
Member

cc: @staticfloat @giordano @maleadt

Installing LLVM 9 on Julia 1.3 can cause two separate version of LLVM to be loaded which makes LLVM.jl rather unhappy.
We should also fix this in BinaryBuilder.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct to me, but it would be great if someone else can also check it.

@staticfloat
Copy link
Member

This is a good first step; but it will be superseded by JuliaLang/julia#33973

@DilumAluthge
Copy link
Member

@vchuravy Can you rebase this on master?

@vchuravy
Copy link
Member Author

This is a good first step; but it will be superseded by JuliaLang/julia#33973

Right, but I am worried about Julia 1.3 & 14

@DilumAluthge
Copy link
Member

I think the syntax is correct on this, but I would appreciate if someone else can confirm.

@vchuravy Just to be safe, can you confirm that when using your branch of the registry, you are able to do things like ] add LLVM_jll? If so, then it's probably safe to merge this.

@vchuravy
Copy link
Member Author

I tested it for LLVM_jll on 1.3

@DilumAluthge DilumAluthge merged commit 630a74f into JuliaRegistries:master Mar 20, 2020
@vchuravy vchuravy deleted the vc/limit_llvm branch April 1, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants