Add --heap-size-hint parameter
#547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilesCranmer
commented
Aug 29, 2024
Comment on lines
+112
to
+114
| def args_from_config(config): | ||
| argv = [config['exepath']] | ||
| for opt, val in config.items(): |
There was a problem hiding this comment.
(This part just cleans up some spooky action at a distance I noticed in the init)
|
LGTM but can you update the docs and changelog please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--heap-size-hintoption that is available to Julia since 1.9: https://julialang.org/blog/2023/04/julia-1.9-highlights/#memory_usage_hint_for_the_gc_with_--heap-size-hint.Fixes #546
Also helps with MilesCranmer/PySR#706. @cjdoris do you think we could get this into a new release fairly quickly? I need this for fixing some OOM issues my users are experiencing.