Support for disabling axis ticks in UnicodePlots

[ivan-boikov]

Fixes #4657

[codecov]

Codecov Report

Patch coverage: 42.85% and project coverage change: +0.13 🎉

Comparison is base (511784f) 90.26% compared to head (9605795) 90.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4681      +/-   ##
==========================================
+ Coverage   90.26%   90.40%   +0.13%     
==========================================
  Files          40       40              
  Lines        8704     8712       +8     
==========================================
+ Hits         7857     7876      +19     
+ Misses        847      836      -11     

Impacted Files	Coverage Δ
src/backends/unicodeplots.jl	93.86% <ø> (ø)
src/axes.jl	89.17% <42.85%> (-0.70%)	⬇️
RecipesPipeline/src/RecipesPipeline.jl	100.00% <0.00%> (ø)
src/args.jl	85.56% <0.00%> (+0.14%)	⬆️
src/backends.jl	82.58% <0.00%> (+0.49%)	⬆️
src/components.jl	90.67% <0.00%> (+0.51%)	⬆️
RecipesPipeline/src/utils.jl	97.26% <0.00%> (+1.36%)	⬆️
RecipesPipeline/src/series.jl	93.58% <0.00%> (+2.56%)	⬆️
src/examples.jl	99.20% <0.00%> (+3.17%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[t-bltg]

In the UnicodePlots context, get_ticks can be expensive (it actually computes ticks which are unused for this backend).

I would instead add a has_ticks helper in axes.jl loosely defined as:

_has_ticks(::Any) = true  # catchall
_has_ticks(s::Symbol) = s !== :none
_has_ticks(::Nothing) = false
_has_ticks(b::Bool) = b

has_ticks(axis) = get(axis, :ticks, nothing) |> _has_ticks

, and use the following instead:

xticks = has_ticks(xaxis),
yticks = has_ticks(yaxis),

[ivan-boikov]

I would instead add a has_ticks helper in axes.jl

Good call. I will also add overloads for Tuple and AbstractVector in a few moments if that's alright.

[t-bltg]

Thanks 👍